[webkit-reviews] review granted: [Bug 69885] Support passing optional filename when FormData.append() is used to append a blob : [Attachment 110616] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 69885: Support passing optional filename when FormData.append() is used to
append a blob
https://bugs.webkit.org/show_bug.cgi?id=69885

Attachment 110616: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=110616&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110616&action=review


Please consider adding that test.

> Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp:78
> +	       filename = toWebCoreStringWithNullCheck(args[2]);

It would be nice to add a test with null as the last arg. It looks like you
added handling throughout the code for this but it seems untested.