[webkit-reviews] review granted: [Bug 64934] [Mac] Embedding PDF with <object> or <embed> fails when there is no MIME type specified : [Attachment 110552] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 11 11:56:01 PDT 2011


mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 64934: [Mac] Embedding PDF with <object> or <embed> fails when there is no
MIME type specified
https://bugs.webkit.org/show_bug.cgi?id=64934

Attachment 110552: proposed fix
https://bugs.webkit.org/attachment.cgi?id=110552&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=110552&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:336
> +	       || (parameters.mimeType.isEmpty() &&
parameters.url.string().lower().endsWith(".pdf")))

This should check the path component of the url rather than the whole string.


More information about the webkit-reviews mailing list