[webkit-reviews] review denied: [Bug 69631] Towards making PopupMenuClient more testable : [Attachment 110151] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 69631: Towards making PopupMenuClient more testable
https://bugs.webkit.org/show_bug.cgi?id=69631

Attachment 110151: Patch
https://bugs.webkit.org/attachment.cgi?id=110151&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110151&action=review


I like the general pattern, but see comments for nits.

> Source/WebCore/rendering/RenderObject.h:301
> +    virtual PopupMenuClient* popupMenuClient() { return 0; }

popupMenuClient() should only be present in derived classes, not here.

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:618
> +    return absoluteBoundingBoxRect(true);

Aren't we using an enum now?

> Source/WebCore/testing/Internals.idl:69
> +	   int popupClientPaddingLeft(in Element element) raises
(DOMException);
> +	   int popupClientPaddingRight(in Element element) raises
(DOMException);

Is it really useful to test paddingLeft and paddingRight?