[webkit-reviews] review granted: [Bug 69432] [Qt][WK2][Mac] QtWebProcess should not show up in the Dock. : [Attachment 109856] patch for review. - dropped the toLocal8Bit() thing.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 5 14:30:28 PDT 2011
Andreas Kling <kling at webkit.org> has granted Zeno Albisser
<zeno.albisser at nokia.com>'s request for review:
Bug 69432: [Qt][WK2][Mac] QtWebProcess should not show up in the Dock.
https://bugs.webkit.org/show_bug.cgi?id=69432
Attachment 109856: patch for review. - dropped the toLocal8Bit() thing.
https://bugs.webkit.org/attachment.cgi?id=109856&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109856&action=review
r=me
> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:84
> +#if defined Q_OS_MACX
I don't think I've ever seen "#if defined X" in WebKit before, let's stick with
"#ifdef X" or "#if defined(X)". Sorry I didn't notice earlier.
More information about the webkit-reviews
mailing list