[webkit-reviews] review granted: [Bug 69386] REGRESSION: Curious Location of StorageTracker.db : [Attachment 109862] Now with more thread-safe\!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 14:25:43 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 69386: REGRESSION: Curious Location of StorageTracker.db
https://bugs.webkit.org/show_bug.cgi?id=69386

Attachment 109862: Now with more thread-safe\!
https://bugs.webkit.org/attachment.cgi?id=109862&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109862&action=review


I don't know if thread safety is a real issue for this function, but the patch
looks good.

> Source/WebKit/mac/Storage/WebStorageManager.mm:35
> +#import <pthread.h>
>  #import <WebCore/SecurityOrigin.h>
>  #import <WebCore/StorageTracker.h>

Alphabetically, upper case comes first.


More information about the webkit-reviews mailing list