[webkit-reviews] review denied: [Bug 69432] [Qt][WK2][Mac] QtWebProcess should not show up in the Dock. : [Attachment 109807] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Zeno Albisser
<zeno.albisser at nokia.com>'s request for review:
Bug 69432: [Qt][WK2][Mac] QtWebProcess should not show up in the Dock.
https://bugs.webkit.org/show_bug.cgi?id=69432

Attachment 109807: Patch
https://bugs.webkit.org/attachment.cgi?id=109807&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109807&action=review


Very nice! :)

> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:85
> +    qputenv("QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM",
QString("1").toLocal8Bit());

We can avoid invoking the ASCII codec by simply passing QByteArray("1") for the
second argument.