[webkit-reviews] review denied: [Bug 64071] new-run-webkit-tests does not support qt-4.8 results : [Attachment 109006] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 09:06:09 PDT 2011


Csaba Osztrogonac <ossy at webkit.org> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 64071: new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Attachment 109006: proposed fix
https://bugs.webkit.org/attachment.cgi?id=109006&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109006&action=review


The development of Qt was faster than this patch's. :) So please update the
patch. 

Now qt-wk2 should fallback to a new qt-5.0 platform. ( After Qt 4.8 will be
releases,
we are going to stop supporting qt-4.7 test results and then we're going to
merge
qt-4.8 results to general qt platform. But it is a mid-term plan.) Otherwise
the patch LGTM.

Is there any objection against landing the fixed patch?

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:33
>  import logging
>  import sys
> +import re

style: alphabetic order

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:111
> +	   if '4.7' in version:
> +	       search_paths.append('qt-4.7')
> +	   elif version:
> +	       search_paths.append('qt-4.8')

if '4.7' in version:
    search_paths.append('qt-4.7')
elif '4.8' in version:
    search_paths.append('qt-4.8')
elif version:
    search_paths.append('qt-5.0')

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:36
>  from webkitpy.layout_tests.port.qt import QtPort
>  from webkitpy.layout_tests.port import port_testcase
>  from webkitpy.tool.mocktool import MockOptions, MockUser, MockExecutive
> +from webkitpy.common.system.executive_mock import MockExecutive2

style: alphabetic order

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:59
> +	       return 'QMake version 2.01a\nUsing Qt version 4.8.2 in
/usr/local/Trolltech/Qt-4.8.2/lib'

nit: s/4.8.2/4.8.0/g

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:78
> +	   self._assert_search_path(['qt-wk2', 'qt-mac', 'qt-4.8', 'qt'],
'darwin', use_webkit2=True, qt_version='5.0')
> +	   self._assert_search_path(['qt-wk2', 'qt-win', 'qt-4.8', 'qt'],
'cygwin', use_webkit2=True, qt_version='5.0')
> +	   self._assert_search_path(['qt-wk2', 'qt-linux', 'qt-4.8', 'qt'],
'linux2', use_webkit2=True, qt_version='5.0')

s/qt-4.8/qt-5.0/g


More information about the webkit-reviews mailing list