[webkit-reviews] review denied: [Bug 10123] when CSS pseudo selectors are applied (:before and :after) the *-of-line keyboard navigation does not work : [Attachment 109275] This patch solves issues regarding navigation and infinite loop cases with CSS pseudo elements before/after .
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 4 11:43:00 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied roseN <rosen.dash at motorola.com>'s
request for review:
Bug 10123: when CSS pseudo selectors are applied (:before and :after) the
*-of-line keyboard navigation does not work
https://bugs.webkit.org/show_bug.cgi?id=10123
Attachment 109275: This patch solves issues regarding navigation and infinite
loop cases with CSS pseudo elements before/after .
https://bugs.webkit.org/attachment.cgi?id=109275&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109275&action=review
> Source/WebCore/ChangeLog:14
> + No new tests as this fixes internal implementation detail.
This change definitely needs a test. From what I understand, keyboard
navigation can be tested by getSelection().modify. r- because of this.
More information about the webkit-reviews
mailing list