[webkit-reviews] review granted: [Bug 62034] [EFL] DRT: Add DumpRenderTree.cpp : [Attachment 109507] Fix a few bugs, rebase on top of trunk

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 62034: [EFL] DRT: Add DumpRenderTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=62034

Attachment 109507: Fix a few bugs, rebase on top of trunk
https://bugs.webkit.org/attachment.cgi?id=109507&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109507&action=review


I know you guys have been working hard to get this in, so I wont hold it to fix
typos.

Congrats!

> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:39
> +#include "ewk_private.h" // FIXME: create some
WebCoreSupport/DumpRenderTree.cpp instead

it could be called DumpRenderTreeSupportEFL :)

> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:162
> +    int option;
> +
> +    while ((option = getopt_long(argc, (char* const*)argv, "", options, 0))
!= -1) {

I would add a new line before "int option" the drop the one below it.

> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:174
> +}
> +
> +
> +static String getFinalTestURL(const String& testURL)

drop one line