[webkit-reviews] review denied: [Bug 69338] Fails to build when sqlite is not in /usr/include : [Attachment 109622] Fix compilation flags typos

[bugzilla-daemon at webkit.org]

Leandro Pereira <leandro at profusion.mobi> has denied Rémi Duraffort
<remi.duraffort at st.com>'s request for review:
Bug 69338: Fails to build when sqlite is not in /usr/include
https://bugs.webkit.org/show_bug.cgi?id=69338

Attachment 109622: Fix	compilation flags typos
https://bugs.webkit.org/attachment.cgi?id=109622&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=109622&action=review


Informal r-.

> Source/WebCore/CMakeListsEfl.txt:243
> -  ${ICU_INCLUDE_DIRS}
> +  ${ICU_INCLUDE_DIR}

FindICU actually sets ICU_INCLUDE_DIRS.

> Source/WebCore/CMakeListsEfl.txt:246
> -  ${LIBXSLT_INCLUDE_DIRS}
> -  ${SQLITE_INCLUDE_DIRS}
> +  ${LIBXSLT_INCLUDE_DIR}
> +  ${SQLITE_INCLUDE_DIR}

This looks fine; however, please mention xslt as well in the ChangeLog entry.

> Source/WebCore/ChangeLog:1
> +2011-10-04  Rémi Duraffort	<remi.duraffort at st.com>

I'll assume this encoding error is Bugzilla's fault.