[webkit-reviews] review denied: [Bug 73280] Upstream credential storage files of BlackBerry porting : [Attachment 117315] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 73280: Upstream credential storage files of BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=73280

Attachment 117315: Patch
https://bugs.webkit.org/attachment.cgi?id=117315&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117315&action=review


it looks good.

r- because we need another round to fix the nits.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:53
> +bool CredentialBackingStore::open(const String& dbPath)

UNUSED_PARAM(dbPath) missing.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:68
> +bool CredentialBackingStore::addLogin(const KURL& url, const
ProtectionSpace& protectionSpace, const Credential& credential)
> +{
> +    notImplemented();
> +    return false;
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:74
> +bool CredentialBackingStore::updateLogin(const KURL& url, const
ProtectionSpace& protectionSpace, const Credential& credential)
> +{
> +    notImplemented();
> +    return false;
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:86
> +Credential CredentialBackingStore::getLogin(const ProtectionSpace&
protectionSpace)
> +{
> +    notImplemented();
> +    return Credential();
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:92
> +{
> +    notImplemented();
> +    return false;
> +}

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.h:55
> +    SQLiteStatement *m_addStatement;
> +    SQLiteStatement *m_updateStatement;
> +    SQLiteStatement *m_hasStatement;
> +    SQLiteStatement *m_getStatement;
> +    SQLiteStatement *m_removeStatement;

* position on the left

> Source/WebCore/platform/network/blackberry/CredentialStorageBlackBerry.cpp:35

> +#else
> +    return Credential();
> +#endif

UNUSED_PARAM needed here too.