[webkit-reviews] review granted: [Bug 73513] [Blackberry] Upstream BlackBerry porting of plugin framework -- part 2 : [Attachment 117318] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 73513: [Blackberry] Upstream BlackBerry porting of plugin framework -- part
2
https://bugs.webkit.org/show_bug.cgi?id=73513

Attachment 117318: Patch
https://bugs.webkit.org/attachment.cgi?id=117318&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review


> Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:183
> +    FrameView* frameView = static_cast<FrameView*>(m_view->parent());
> +
> +    if (preventIdle == m_idlePrevented)
> +	   return;

we could move the early return before the ' frameview = xxx' lines.

> Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:325
> +    for (int i = 0; (i < PLUGIN_BUFFERS) && success; i++) {

unneeded ()