[webkit-reviews] review requested: [Bug 71625] Web Inspector: Preserve an indentation level when inserting a new line : [Attachment 117149] Simplify normalize

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <me at elv1s.ru> has asked  for review:
Bug 71625: Web Inspector: Preserve an indentation level when inserting a new
line
https://bugs.webkit.org/show_bug.cgi?id=71625

Attachment 117149: Simplify normalize
https://bugs.webkit.org/attachment.cgi?id=117149&action=review

------- Additional Comments from Nikita Vasilyev <me at elv1s.ru>
(In reply to comment #25)
> (From update of attachment 117028 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=117028&action=review
> 
> > Source/WebCore/inspector/front-end/TextEditorModel.js:63
> > +		 return new WebInspector.TextRange(this.startLine,
this.startColumn, this.endLine, this.endColumn);
> 
> "return this;" would work given that we consider range immutable.

Done.

> > Source/WebCore/inspector/front-end/TextViewer.js:1168
> > +		 // {|}
> 
> I would expect
> function foo() {|}
> 
> to become
> 
> function foo() {
>     |
> }
> 
> will it work?

Sure it will.