[webkit-reviews] review canceled: [Bug 71625] Web Inspector: Preserve an indentation level when inserting a new line : [Attachment 117028] Immutable TextRange
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 30 02:19:41 PST 2011
Nikita Vasilyev <me at elv1s.ru> has canceled Nikita Vasilyev <me at elv1s.ru>'s
request for review:
Bug 71625: Web Inspector: Preserve an indentation level when inserting a new
line
https://bugs.webkit.org/show_bug.cgi?id=71625
Attachment 117028: Immutable TextRange
https://bugs.webkit.org/attachment.cgi?id=117028&action=review
------- Additional Comments from Nikita Vasilyev <me at elv1s.ru>
(In reply to comment #25)
> (From update of attachment 117028 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=117028&action=review
>
> > Source/WebCore/inspector/front-end/TextEditorModel.js:63
> > + return new WebInspector.TextRange(this.startLine,
this.startColumn, this.endLine, this.endColumn);
>
> "return this;" would work given that we consider range immutable.
Done.
> > Source/WebCore/inspector/front-end/TextViewer.js:1168
> > + // {|}
>
> I would expect
> function foo() {|}
>
> to become
>
> function foo() {
> |
> }
>
> will it work?
Sure it will.
More information about the webkit-reviews
mailing list