[webkit-reviews] review granted: [Bug 57206] Don't apply :hover to elements that are :active, but don't contain the mouse : [Attachment 115303] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Jeremy Apthorp
<jeremya at chromium.org>'s request for review:
Bug 57206: Don't apply :hover to elements that are :active, but don't contain
the mouse
https://bugs.webkit.org/show_bug.cgi?id=57206

Attachment 115303: Patch
https://bugs.webkit.org/attachment.cgi?id=115303&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115303&action=review


Looks sane. Please fix the nits before you land.

> Source/WebCore/ChangeLog:4
> +	   When the mouse is dragged out of an :active element, it should lose
> +	   :hover.

Please fit these two lines in one line to avoid the awkward line break.

> Source/WebCore/ChangeLog:13
> +	   (WebCore::EventHandler::handleMouseMoveEvent):
> +	   Don't mark mouse-drag hit tests read-only, since they no longer are.


We typically put the description after : followed by one space.

> Source/WebCore/ChangeLog:15
> +	   (WebCore::EventHandler::dragSourceEndedAt):
> +	   Send a hit test request when the mouse goes up after a drag, so

Ditto.

> Source/WebCore/ChangeLog:19
> +	   (WebCore::RenderLayer::updateHoverActiveState):
> +	   Only allow the :active state to change on mouse down or mouse up.

Ditto.

> LayoutTests/ChangeLog:4
> +	   When the mouse is dragged out of an :active element, it should lose
> +	   :hover.

Ditto.