[webkit-reviews] review denied: [Bug 3402] unload event doesn't fire : [Attachment 110502] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 3402: unload event doesn't fire
https://bugs.webkit.org/show_bug.cgi?id=3402

Attachment 110502: Patch
https://bugs.webkit.org/attachment.cgi?id=110502&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110502&action=review


> Source/WebCore/ChangeLog:6
> +	   Fix addEventListener("unload") for body elements by propegating to
the window object.

I'm not sure if want to support document.body.addEventListener. It seems like
it makes more sense to support document.body.setAttribute('onunload', ...).

> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

This line should appear before the description.

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

We definitely need a test for this. r- because of this.