[webkit-reviews] review denied: [Bug 72626] [GTK] Integrate build-gtkdoc into build-webkit and make : [Attachment 116498] Fix a couple bugs

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 72626: [GTK] Integrate build-gtkdoc into build-webkit and make
https://bugs.webkit.org/show_bug.cgi?id=72626

Attachment 116498: Fix a couple bugs
https://bugs.webkit.org/attachment.cgi?id=116498&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116498&action=review


Nice patch! r- mostly because of the webkit-build-directory issue

> Tools/GNUmakefile.am:260
> +	@rm -rf Documentation/webkitgtk Documentation/webkit2gtk
> +	- at rmdir Documentation

Can that be replaced with rm -rf Documentation?

> Tools/gtk/generate-gtkdoc:58
> +    process = subprocess.Popen(['perl',
script_path('webkit-build-directory'), '--configuration', 'gtk'],
> +				  stdout=subprocess.PIPE)

This will always return the path to a Release build because we never call
set-webkit-configuration :(