[webkit-reviews] review granted: [Bug 69835] [GStreamer] WebAudio AudioDestination : [Attachment 116355] WebAudio GStreamer implementation: playback support

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 69835: [GStreamer] WebAudio AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=69835

Attachment 116355: WebAudio GStreamer implementation: playback support
https://bugs.webkit.org/attachment.cgi?id=116355&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116355&action=review


> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:106
> +    // Autoaudiosink does the real sink detection in the
> +    // GST_STATE_NULL->READY transition so it's best to roll it to READY as
> +    // soon as possible to ensure the underlying platform
> +    // audiosink was loaded correctly.

Super nit: Do you mind evening out these lines?

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:324

> +    if (!priv->provider || !priv->bus)
> +	   return;

You can probably remove this since you assert above.