[webkit-reviews] review canceled: [Bug 72866] Accessibility: AccessibilityController should support listening to notifications on all elements. : [Attachment 116088] Patch

[bugzilla-daemon at webkit.org]

Dominic Mazzoni <dmazzoni at google.com> has canceled Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 72866: Accessibility: AccessibilityController should support listening to
notifications on all elements.
https://bugs.webkit.org/show_bug.cgi?id=72866

Attachment 116088: Patch
https://bugs.webkit.org/attachment.cgi?id=116088&action=review

------- Additional Comments from Dominic Mazzoni <dmazzoni at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116088&action=review


>> Source/WebKit/chromium/src/ChromeClientImpl.cpp:120
>>	case AXObjectCache::AXActiveDescendantChanged:
> 
> Is it possible to just make the enums defined on AXObjectCache and their
reflection through the API have exactly the same values such that a simple cast
could replace this switch/case statement?  That's how we handle reflecting most
other enum values.  Then, to keep the API ones consistent with their WebCore
counterparts, we extend AssertMatchingEnums.cpp.

Good idea. I split this into a separate bug -
https://bugs.webkit.org/show_bug.cgi?id=72895 - patch coming momentarily. Then
I can remove all of those files from this change.