[webkit-reviews] review denied: [Bug 72853] Needs WTF_INLINE and JS_INLINE : [Attachment 116037] Patch

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 72853: Needs WTF_INLINE and JS_INLINE
https://bugs.webkit.org/show_bug.cgi?id=72853

Attachment 116037: Patch
https://bugs.webkit.org/attachment.cgi?id=116037&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116037&action=review


> Source/JavaScriptCore/wtf/ExportMacros.h:38
> +#define WTF_HIDDEN __attribute__((visibility("hidden")))

This is using the gcc syntax for hidden symbols inside of the !COMPILER(GCC)
block. In MSVC, hidden is the default visibility, so we should probably just
define WTF_HIDDEN as an empty string here. 

Otherwise, looks fine, so I'll r+ once this is fixed.