[webkit-reviews] review requested: [Bug 72591] Remove document.width / document.height : [Attachment 115847] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 18 12:27:32 PST 2011
Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked for review:
Bug 72591: Remove document.width / document.height
https://bugs.webkit.org/show_bug.cgi?id=72591
Attachment 115847: proposed patch
https://bugs.webkit.org/attachment.cgi?id=115847&action=review
------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #7)
> (In reply to comment #6)
> > If these functions are exposed in the ObjC bindings, then we can't remove
the implementation. We could potentially restrict the API to just ObjC though.
>
> This is what we did for initOverflowEvent in bug 71687. It was public
Objective C API; it is now in the Objective C binding only.
Attaching as per above review comments. Moved height/width attribute under
"LANGUAGE_OBJECTIVE_C"
Please let me know your comments on this.
More information about the webkit-reviews
mailing list