[webkit-reviews] review denied: [Bug 72539] FilterOperation* should stay in rendering/style, because it is directly referenced from RenderStyle : [Attachment 115555] Patch v1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 72539: FilterOperation* should stay in rendering/style, because it is
directly referenced from RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=72539

Attachment 115555: Patch v1
https://bugs.webkit.org/attachment.cgi?id=115555&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115555&action=review


If we agree this is the correct approach, then r=me (but r- for forgetting the
CMakefile change)

> Source/WebCore/ChangeLog:73
> +	   * rendering/style/CustomFilterOperation.h: Renamed from
Source/WebCore/platform/graphics/filters/CustomFilterOperation.h.
> +	   (WebCore::CustomFilterOperation::create):
> +	   (WebCore::CustomFilterOperation::setVertexShader):
> +	   (WebCore::CustomFilterOperation::vertexShader):
> +	   (WebCore::CustomFilterOperation::setFragmentShader):
> +	   (WebCore::CustomFilterOperation::fragmentShader):
> +	   (WebCore::CustomFilterOperation::operator==):
> +	   (WebCore::CustomFilterOperation::CustomFilterOperation):
> +	   * rendering/style/FilterOperation.h: Renamed from
Source/WebCore/platform/graphics/filters/FilterOperation.h.
> +	   (WebCore::FilterOperation::~FilterOperation):
> +	   (WebCore::FilterOperation::operator!=):
> +	   (WebCore::FilterOperation::getOperationType):
> +	   (WebCore::FilterOperation::isSameType):
> +	   (WebCore::FilterOperation::FilterOperation):
> +	   (WebCore::ReferenceFilterOperation::create):
> +	   (WebCore::ReferenceFilterOperation::reference):
> +	   (WebCore::ReferenceFilterOperation::operator==):
> +	   (WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
> +	   (WebCore::BasicColorMatrixFilterOperation::create):
> +	   (WebCore::BasicColorMatrixFilterOperation::amount):
> +	   (WebCore::BasicColorMatrixFilterOperation::operator==):
> +	  
(WebCore::BasicColorMatrixFilterOperation::BasicColorMatrixFilterOperation):
> +	   (WebCore::BasicComponentTransferFilterOperation::create):
> +	   (WebCore::BasicComponentTransferFilterOperation::amount):
> +	   (WebCore::BasicComponentTransferFilterOperation::operator==):
> +	  
(WebCore::BasicComponentTransferFilterOperation::BasicComponentTransferFilterOp
eration):
> +	   (WebCore::GammaFilterOperation::create):
> +	   (WebCore::GammaFilterOperation::amplitude):
> +	   (WebCore::GammaFilterOperation::exponent):
> +	   (WebCore::GammaFilterOperation::offset):
> +	   (WebCore::GammaFilterOperation::operator==):
> +	   (WebCore::GammaFilterOperation::GammaFilterOperation):
> +	   (WebCore::BlurFilterOperation::create):
> +	   (WebCore::BlurFilterOperation::stdDeviationX):
> +	   (WebCore::BlurFilterOperation::stdDeviationY):
> +	   (WebCore::BlurFilterOperation::operator==):
> +	   (WebCore::BlurFilterOperation::BlurFilterOperation):
> +	   (WebCore::SharpenFilterOperation::create):
> +	   (WebCore::SharpenFilterOperation::amount):
> +	   (WebCore::SharpenFilterOperation::radius):
> +	   (WebCore::SharpenFilterOperation::threshold):
> +	   (WebCore::SharpenFilterOperation::operator==):
> +	   (WebCore::SharpenFilterOperation::SharpenFilterOperation):
> +	   (WebCore::DropShadowFilterOperation::create):
> +	   (WebCore::DropShadowFilterOperation::x):
> +	   (WebCore::DropShadowFilterOperation::y):
> +	   (WebCore::DropShadowFilterOperation::stdDeviation):
> +	   (WebCore::DropShadowFilterOperation::color):
> +	   (WebCore::DropShadowFilterOperation::operator==):
> +	   (WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
> +	   * rendering/style/FilterOperations.cpp: Renamed from
Source/WebCore/platform/graphics/filters/FilterOperations.cpp.
> +	   (WebCore::FilterOperations::FilterOperations):
> +	   (WebCore::FilterOperations::operator==):
> +	   * rendering/style/FilterOperations.h: Renamed from
Source/WebCore/platform/graphics/filters/FilterOperations.h.
> +	   (WebCore::FilterOperations::operator!=):
> +	   (WebCore::FilterOperations::clear):
> +	   (WebCore::FilterOperations::operations):
> +	   (WebCore::FilterOperations::size):
> +	   (WebCore::FilterOperations::at):

I think we can remove all the (WebCore::) bits here since it is just a rename.