[webkit-reviews] review granted: [Bug 72131] REGRESSION (r99924): broke 2 pasteboard tests on GTK : [Attachment 115763] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 18 10:47:17 PST 2011


Tony Chang <tony at chromium.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 72131: REGRESSION (r99924): broke 2 pasteboard tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=72131

Attachment 115763: Patch
https://bugs.webkit.org/attachment.cgi?id=115763&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115763&action=review


> Source/WebCore/platform/gtk/ClipboardGtk.cpp:120
>      default:

Nit: Can we convert this default: into ClipboardDataTypeImage:?  Then the
compiler will be able to warn us in the future if we add a new type.


More information about the webkit-reviews mailing list