[webkit-reviews] review granted: [Bug 72685] [CMake] Move the top-level logic to the top-level directory. : [Attachment 115828] Rebase on top of Patrick's recent CMake commits

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 72685: [CMake] Move the top-level logic to the top-level directory.
https://bugs.webkit.org/show_bug.cgi?id=72685

Attachment 115828: Rebase on top of Patrick's recent CMake commits
https://bugs.webkit.org/attachment.cgi?id=115828&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115828&action=review


Looks good.  Holding cq+ until buildbot maintainer can update build
configuration.

> Source/JavaScriptCore/CMakeLists.txt:20
> +    "${CMAKE_SOURCE_DIR}/Source"

It seems funny that CMAKE_SOURCE_DIR doesn't have Source as part of its path. 
I guess it's really more a "CMAKE_ROOT_BUILD_DIR"?