[webkit-reviews] review requested: [Bug 72602] [Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore : [Attachment 115643] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 11:51:41 PST 2011


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 72602: [Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=72602

Attachment 115643: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=115643&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
I debugged and fixed this issue on a Mac by locally disabling
WTF_USE_ICU_UNICODE in WebCore/editing/TextIterator.cpp.  The proposed patch
fixed the issues, but the expected results for the impacted tests as well as a
few others are different on Mac than on qt.  Therefore I'd like someone working
on qt to verify that this does fix the test failures in a qt build.


More information about the webkit-reviews mailing list