[webkit-reviews] review denied: [Bug 72601] [GTK] enable ref tests : [Attachment 115635] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 17 11:51:47 PST 2011


Tony Chang <tony at chromium.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 72601: [GTK] enable ref tests
https://bugs.webkit.org/show_bug.cgi?id=72601

Attachment 115635: Patch
https://bugs.webkit.org/attachment.cgi?id=115635&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115635&action=review


Thanks for tracking this down!

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:53
> +	   if self._pixel_tests:
> +	       display_id += 20

We have machines with 24 cores.  Instead of adding a constant, we could have:
display_id = (self._worker_number + 1) * 2
if self._pixel_tests:
    display_id += 1


More information about the webkit-reviews mailing list