[webkit-reviews] review granted: [Bug 72546] De-virtualize ScriptExecutable::unlinkCalls : [Attachment 115447] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 72546: De-virtualize ScriptExecutable::unlinkCalls
https://bugs.webkit.org/show_bug.cgi?id=72546

Attachment 115447: Patch
https://bugs.webkit.org/attachment.cgi?id=115447&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115447&action=review


r=me

> Source/JavaScriptCore/runtime/Executable.h:692
> +	   switch (structure()->typeInfo().type()) {

i'd like to understand better when we use ClassInfo and when we use a JSType.
Do you have a rule for that?

> Source/JavaScriptCore/runtime/JSType.h:56
> +    StaticScopeObjectType = 22,

Yeah, I really think you want to remove the explicit numeric values for these
enumerated constants.