[webkit-reviews] review granted: [Bug 72548] De-virtualize ExecutableBase::intrinsic : [Attachment 115450] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 72548: De-virtualize ExecutableBase::intrinsic
https://bugs.webkit.org/show_bug.cgi?id=72548

Attachment 115450: Patch
https://bugs.webkit.org/attachment.cgi?id=115450&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115450&action=review


r=me

> Source/JavaScriptCore/runtime/Executable.cpp:57
> +    if (structure()->typeInfo().type() == NativeExecutableType)
> +	   return jsCast<const NativeExecutable*>(this)->intrinsic();

Could just use classInfo here instead of a type flag. 

I mention this because it might be nice to deploy jsDynamicCast here, and I
assume jsDynamicCast would be based on ClassInfo.

> Source/JavaScriptCore/runtime/JSType.h:54
>  };

Do we really need to spell these constants out explicitly? Do their bits have
any meaning?