[webkit-reviews] review denied: [Bug 72100] Accessibility: new iframe content may not be reflected in ax tree : [Attachment 114645] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 72100: Accessibility: new iframe content may not be reflected in ax tree
https://bugs.webkit.org/show_bug.cgi?id=72100

Attachment 114645: Patch
https://bugs.webkit.org/attachment.cgi?id=114645&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114645&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:441
> +

i'm not sure this will be true on webkit1. on wk1 the web area's parent should
be an attachment

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3422
>	   

I think we could remove this isAccessibilityRenderObject restriction and
postNotification can take an axObject instead. that will reduce the code in
this method and you won't need to add your comment

> Source/WebCore/accessibility/AccessibilityRenderObject.h:207
>      

since this method is in AXObject.h now as public, it does not need to be public
in AXRenderObject

> Source/WebCore/accessibility/AccessibilityScrollView.cpp:183
> +

what's up with this change?

> Source/WebCore/dom/Document.cpp:2232
>      }

this change is not reflected in the layout test. it should be in a different
bug