[webkit-reviews] review granted: [Bug 72023] [GStreamer] GstCaps and GstPad RefPtr implementation : [Attachment 114697] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 72023: [GStreamer] GstCaps and GstPad RefPtr implementation
https://bugs.webkit.org/show_bug.cgi?id=72023

Attachment 114697: proposed patch
https://bugs.webkit.org/attachment.cgi?id=114697&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114697&action=review


Looks good, but please fix the minor issues below before landing. Thanks!

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1753

> +    pad.clear();
> +    pad = adoptGRef(gst_element_get_static_pad(m_webkitVideoSink, "sink"));

You shouldn't need to clear the pad first, you can just reassign it.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:234
> +    GRefPtr<GstPad> targetPad =
gst_element_get_static_pad(GST_ELEMENT(priv->appsrc), "src");

Missing adoptGRef here?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:733
> +	       GRefPtr<GstCaps> caps = gst_caps_new_simple("application/x-icy",
"metadata-interval", G_TYPE_INT, (gint) icyMetaInt, NULL);

Also need to use adoptRef here as well.