[webkit-reviews] review granted: [Bug 72071] Add jsCast to replace static_cast : [Attachment 114615] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 72071: Add jsCast to replace static_cast
https://bugs.webkit.org/show_bug.cgi?id=72071

Attachment 114615: Patch
https://bugs.webkit.org/attachment.cgi?id=114615&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114615&action=review


r=me

> Source/JavaScriptCore/runtime/JSCell.h:333
> +    template <typename To, typename From>

Should be no space before "<". (Think of template arguments just like function
arguments.)

> Source/JavaScriptCore/runtime/JSCell.h:336
> +	   ASSERT(from->classInfo() == &WTF::RemovePointer<To>::Type::s_info ||
from->inherits(&WTF::RemovePointer<To>::Type::s_info));

Since you're checking inherits(), I don't think you need to check ==. == is a
subset of inherits().