[webkit-reviews] review granted: [Bug 72089] JSString forgets to clear m_fibers when resolving ropes : [Attachment 114626] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 72089: JSString forgets to clear m_fibers when resolving ropes
https://bugs.webkit.org/show_bug.cgi?id=72089

Attachment 114626: the patch
https://bugs.webkit.org/attachment.cgi?id=114626&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114626&action=review


> Source/JavaScriptCore/runtime/JSString.cpp:109
> +	   // Clearing here works only because there are no GC points in this
method.

Might be good to merge this with the comment above, which ASSERTs that using a
Vector is OK -- really, using a Vector is only OK because GC just won't happen.