[webkit-reviews] review denied: [Bug 72010] Add new API for Vibration API spec. : [Attachment 114467] Core part for the Vibration API

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 72010: Add new API for Vibration API spec.
https://bugs.webkit.org/show_bug.cgi?id=72010

Attachment 114467: Core part for the Vibration API
https://bugs.webkit.org/attachment.cgi?id=114467&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114467&action=review


This patch is missing tests.  At this point, we just need basic tests for
showing that the API exists and you can call it (not necessarily that it does
anything).

> Source/WebCore/bindings/js/JSNavigatorCustom.cpp:66
> +JSValue JSNavigator::webkitVibrate(ExecState* exec)

This shouldn't need custom bindings.

> Source/WebCore/page/Navigator.h:29
> +typedef Vector<long, 1> VibrationArray;

Why have an inline capacity of 1?

> Source/WebCore/page/Navigator.idl:64
> +#if defined(ENABLE_VIBRATION) && ENABLE_VIBRATION
> +	   [Custom] void webkitVibrate(in [Optional=CallWithDefaultValue] Array
pattern)
> +	       raises(DOMException);
> +#endif

This API shouldn't be custom.