[webkit-reviews] review denied: [Bug 72023] [GStreamer] GstCaps and GstPad RefPtr implementation : [Attachment 114493] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 72023: [GStreamer] GstCaps and GstPad RefPtr implementation
https://bugs.webkit.org/show_bug.cgi?id=72023

Attachment 114493: proposed patch
https://bugs.webkit.org/attachment.cgi?id=114493&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114493&action=review


Look like you are forgetting to use adoptGRef. Other than that this patch looks
good. Thank you!

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:44
> +	   gst_object_ref(GST_OBJECT(ptr));

I think you should use gst_object_ref_sink here.

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:57
> +	   gst_caps_ref(ptr);

And here as well.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:95
> +    GRefPtr<GstElement> tee = gst_bin_get_by_name(GST_BIN(videoSink.get()),
"videoTee");

You need to call adoptGRef here if you don't want to leak the tee.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:107
> +    GRefPtr<GstPad> srcPad = gst_element_get_request_pad(tee.get(),
"src%d");
> +    GRefPtr<GstPad> sinkPad = gst_element_get_static_pad(queue, "sink");

Ditto.

> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:163
> +    GRefPtr<GstElement> tee = gst_bin_get_by_name(GST_BIN(videoSink.get()),
"videoTee");

The same for all of these as well.