[webkit-reviews] review granted: [Bug 69108] Parse drop-shadow() filter syntax : [Attachment 114425] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 69108: Parse drop-shadow() filter syntax
https://bugs.webkit.org/show_bug.cgi?id=69108

Attachment 114425: Patch
https://bugs.webkit.org/attachment.cgi?id=114425&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114425&action=review


r+ but please remove the FIXME

> Source/WebCore/css/CSSParser.cpp:6507
> +	   maximumArgumentCount = 5; // FIXME: is this right?

Is it?

> Source/WebCore/css/CSSParser.cpp:6750
> +		   RefPtr<CSSValueList> shadowValueList = parseShadow(args,
CSSPropertyWebkitFilter);

I think it's a bit odd to re-use parseShadow for this filter.