[webkit-reviews] review granted: [Bug 71574] [NRWT] result.html should not rely on naming convention of reference file used in reftests. : [Attachment 114439] fixed variable name, port

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 71574: [NRWT] result.html should not rely on naming convention of reference
file used in reftests.
https://bugs.webkit.org/show_bug.cgi?id=71574

Attachment 114439: fixed variable name, port
https://bugs.webkit.org/attachment.cgi?id=114439&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114439&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:94
> +	       if failure.reference_filename !=
port.reftest_expected_filename(test_name):
> +		   test_dict['ref_file'] =
port.relative_test_filename(failure.reference_filename)

I still think we can always add ref_file but that might bloat the json?

> LayoutTests/fast/harness/results.html:415
> +function referenceLink(testPrefix, reference_filename, contents)
> +{
> +    return '<a class=result-link href="' + reference_filename + '"
data-prefix="' + testPrefix + '">' + contents + '</a> ';
> +}

Maybe we can share the code with resultLink?