[webkit-reviews] review denied: [Bug 71983] Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue : [Attachment 114414] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 71983: Add Environment object to Host and fix the GCC smartquotes trouble
seen on the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=71983

Attachment 114414: Patch
https://bugs.webkit.org/attachment.cgi?id=114414&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114414&action=review


> Tools/Scripts/webkitpy/common/system/environment_mock.py:38
> +    @classmethod
> +    def disable_gcc_smartquotes(self, env):

I think you want the Host to vend your a mutable Environment object that has a
getter that returns the env dictionary.  The MockHost can then vend you a legit
Environment object with a dictionary initialized to something independent of
the actual environment.