[webkit-reviews] review denied: [Bug 71388] [Chromium] Add support for painting into an SkPicture and then rasterizing into tile-sized chunks : [Attachment 114365] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 71388: [Chromium] Add support for painting into an SkPicture and then
rasterizing into tile-sized chunks
https://bugs.webkit.org/show_bug.cgi?id=71388

Attachment 114365: Patch
https://bugs.webkit.org/attachment.cgi?id=114365&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114365&action=review


Very very close! Just two more nits.

> Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h:52
> +	   virtual void prepareRect(const IntRect& sourceRect) { };

you don't need a semicolon at the end of this line

this will have the unused parameter issue - don't name the parameter or put the
parameter name in comments like so:

virtual void prepareRect(const IntRect& /* sourceRect */) { }

or just make it pure virtual (that might make most sense, this class isn't
instantiable anyway)

> Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h:81
> +    virtual void prepareToUpdate(const IntRect& contentRect, const IntSize&
tileSize, int borderTexels) { };

no semicolon at end of line