[webkit-reviews] review granted: [Bug 71386] Use dumpAsText for printing layout test : [Attachment 114359] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 14:58:32 PST 2011


Tony Chang <tony at chromium.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 71386: Use dumpAsText for printing layout test
https://bugs.webkit.org/show_bug.cgi?id=71386

Attachment 114359: patch
https://bugs.webkit.org/attachment.cgi?id=114359&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
I think this change is fine (less pixel results to maintain), but as someone
not familiar with the test, it's not obvious how to tell if the test passes or
not.  If there were some way to determine that (say by analyzing the text in
script instead of dumping it a node), that would be better.


More information about the webkit-reviews mailing list