[webkit-reviews] review granted: [Bug 71862] Towards 8 Bit Strings: Templatize JSC::LiteralParser class by character type : [Attachment 114363] Updated Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 71862: Towards 8 Bit Strings: Templatize JSC::LiteralParser class by
character type
https://bugs.webkit.org/show_bug.cgi?id=71862

Attachment 114363: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=114363&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114363&action=review


r=me

> Source/JavaScriptCore/ChangeLog:6
> +	   Changed LiteralParser to be templatized of character type.

s/of/on

> Source/JavaScriptCore/ChangeLog:8
> +	   Moved five enums out of class definition to work around a clang
compiler defect.

sadness, have you filed a bug on that?