[webkit-reviews] review granted: [Bug 71868] Remove redundant [CanBeConstructed] IDLs : [Attachment 114302] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 9 09:28:16 PST 2011


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 71868: Remove redundant [CanBeConstructed] IDLs
https://bugs.webkit.org/show_bug.cgi?id=71868

Attachment 114302: Patch
https://bugs.webkit.org/attachment.cgi?id=114302&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114302&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2382
> -    if ($dataNode->extendedAttributes->{"CanBeConstructed"} ||
$dataNode->extendedAttributes->{"CustomConstructor"} ||
$dataNode->extendedAttributes->{"V8CustomConstructor"} ||
$dataNode->extendedAttributes->{"Constructer"}) {
> +    if ($dataNode->extendedAttributes->{"CanBeConstructed"} ||
$dataNode->extendedAttributes->{"CustomConstructor"} ||
$dataNode->extendedAttributes->{"V8CustomConstructor"} ||
$dataNode->extendedAttributes->{"Constructor"}) {

Sorry I missed in the last patch!


More information about the webkit-reviews mailing list