[webkit-reviews] review denied: [Bug 71854] Access key should work on all elements : [Attachment 114247] Proposed Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 71854: Access key should work on all elements
https://bugs.webkit.org/show_bug.cgi?id=71854

Attachment 114247: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=114247&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114247&action=review


r- because there are redundant IDL attribute entries.

>> LayoutTests/fast/forms/access-key-for-all-elements.html:8
>> +<div id="test"></div>
> 
> Currently it is checking only for DIV element which doesn't works with
"accessKey" by default. With this patch it is expected to work now for DIV as
well as all other elements.
> I tried to have test to check for all element but couldn't find any. Please
let me know if anyone have better thoughts to check for all "Elements", thanks.


We need to test more than just div. I suggest you copy the list of elements out
of HTMLNames and test all elements in some loop.