[webkit-reviews] review denied: [Bug 71848] Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement. : [Attachment 114147] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 71848: Web Inspector: ResourcesPanel should support adding subtitle to any
BaseStorageTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=71848

Attachment 114147: Patch
https://bugs.webkit.org/attachment.cgi?id=114147&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114147&action=review


> Source/WebCore/inspector/front-end/ResourcesPanel.js:870
> +	   this._updateTitles();

I know why you are setting titles when element is in the tree, but you could
'force' it and do it before.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:929
> +	   this._updateTitles();

So the common sequence below is at risk of creating title element twice?:
treeElement.titleText = "foo";
treeElement.subtitleText = "bar";

I would manage title setters separately: title setter only changes its text,
while preserving the subtitle + subtitle lazily creates / updates subtitle
element. And you have to force both on attach.