[webkit-reviews] review denied: [Bug 71850] Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView. : [Attachment 114143] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 71850: Web Inspector: Extract ApplicationCacheModel from
ApplicationCacheItemsView.
https://bugs.webkit.org/show_bug.cgi?id=71850

Attachment 114143: Patch
https://bugs.webkit.org/attachment.cgi?id=114143&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114143&action=review


> Source/WebCore/inspector/front-end/inspector.js:347
> +    this.applicationCacheModel = new WebInspector.ApplicationCacheModel();

We should not run appcache initialization code + request appcaches on load and
should not make applicationCacheModel instance public. I'd suggest that you
keep the private pointer to it in the view + create it lazily.