[webkit-reviews] review granted: [Bug 70614] [Chromium] Expose deviceScaleFactor to WebKit API : [Attachment 113569] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 70614: [Chromium] Expose deviceScaleFactor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=70614

Attachment 113569: Patch
https://bugs.webkit.org/attachment.cgi?id=113569&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113569&action=review


> Source/WebKit/chromium/public/WebView.h:219
> +    // Used by the viewport tag. The ratio of the current device's screen
DPI to the target

nit: comments like "Used by the viewport tag" could pretty quickly become
stale.
if someone else starts using the deviceScaleFactor information for something
else,
then they would most likely not think to update this comment.  as this is API
comments, it probably doesn't matter to the embedder how this field will be
used.
instead, they just need to know what the field means and what they may set its
value to be.  recommendation: leave out the "Used by the viewport tag" bit.