[webkit-reviews] review denied: [Bug 71478] Fix up chromium API for creating events, initializing message events : [Attachment 113506] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 3 22:36:16 PDT 2011
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dave Michael
<dmichael at chromium.org>'s request for review:
Bug 71478: Fix up chromium API for creating events, initializing message events
https://bugs.webkit.org/show_bug.cgi?id=71478
Attachment 113506: Patch
https://bugs.webkit.org/attachment.cgi?id=113506&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113506&action=review
> Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:58
> + static_cast<const WebFrameImpl*>(sourceFrame)->frame()->domWindow();
don't you need to assign domWindow() to 'window' ?
More information about the webkit-reviews
mailing list