[webkit-reviews] review granted: [Bug 71466] [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API : [Attachment 113476] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 71466: [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71466

Attachment 113476: Patch
https://bugs.webkit.org/attachment.cgi?id=113476&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113476&action=review


> Tools/MiniBrowser/gtk/BrowserWindow.c:101
> +	   return 0;

0 -> NULL

> Tools/MiniBrowser/gtk/BrowserWindow.c:110
> +	   GtkAction *action = gtk_action_new(uri, title, 0, 0);

This is C so the zeros should be NULL, I think.

> Tools/MiniBrowser/gtk/BrowserWindow.c:111
> +	   g_object_set_data_full(G_OBJECT(action), "back-forward-list-item",
g_object_ref(item), (GDestroyNotify)g_object_unref);

You might not need to cast GDestroyNotify here. Please check before landing.