[webkit-reviews] review granted: [Bug 71474] [GTK] Show url of history items in a status bar in MiniBrowser : [Attachment 113491] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 71474: [GTK] Show url of history items in a status bar in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71474

Attachment 113491: Patch
https://bugs.webkit.org/attachment.cgi?id=113491&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113491&action=review


Okay.

> Tools/MiniBrowser/gtk/BrowserWindow.c:43
> +    GtkWidget *statusLabel;

statusLabel -> statusOverlay ?

> Tools/MiniBrowser/gtk/BrowserWindow.c:58
> +#if GTK_CHECK_VERSION(3, 2, 0)

So it begins. :(

> Tools/MiniBrowser/gtk/BrowserWindow.c:66
> +    browserWindowSetStatusText(window, 0);

0 -> NULL

> Tools/MiniBrowser/gtk/BrowserWindow.c:106
> +    browserWindowSetStatusText(window, action ? gtk_action_get_name(action)
: 0);

0 -> NULL

> Tools/MiniBrowser/gtk/BrowserWindow.c:268
> +    window->statusLabel = gtk_label_new(0);

0 -> NULL