[webkit-reviews] review granted: [Bug 71409] [Qt] Flagging usage of X11 headers under PLAT_ARCH(X11) : [Attachment 113383] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 3 00:22:27 PDT 2011


Simon Hausmann <hausmann at webkit.org> has granted Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 71409: [Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
https://bugs.webkit.org/show_bug.cgi?id=71409

Attachment 113383: patch
https://bugs.webkit.org/attachment.cgi?id=113383&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I guess that'll do as a build fix as it's consistent with the usage the same
guards around QX11Info later in the file. But I think the correct fix is to
include QX11Info for Qt 4.x and use the QPlatformNativeInterface in Qt 5 to
retrieve the display. I admit that requires more than just a build fix, so r=me
for this one :)


More information about the webkit-reviews mailing list