[webkit-reviews] review granted: [Bug 71436] DFG inlining breaks function.arguments[something] if the argument being retrieved was subjected to DFG's unboxing optimizations : [Attachment 113438] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 71436: DFG inlining breaks function.arguments[something] if the argument
being retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436

Attachment 113438: the patch
https://bugs.webkit.org/attachment.cgi?id=113438&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113438&action=review


r+, but i don't see any reason not to merge stackOffset and isCall

> Source/JavaScriptCore/bytecode/CodeOrigin.h:84
>      unsigned stackOffset;
> -    unsigned numArgumentsIncludingThis : 31;
> -    bool isCall : 1;
> +    bool isCall;

Can we merge stackOffset and isCall here?  I can't see us needing a 1gig stack
offset...